Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where the navigation buttons were invisible in markdown view #1152

Merged
merged 1 commit into from
May 16, 2024

Conversation

charliescheer
Copy link
Contributor

@charliescheer charliescheer commented May 14, 2024

Fix

On Mac, when you tap on the Markdown view button we display the note text in a webkit view. The background color of this view is currently blocking out the navigation buttons so you can't see where they are to turn off the markdown view.

In this PR I have updated markdown view background color to clear. The other views backgrounds still supply the background color so the markdown view appearance is the same but you can see the buttons.

Test

  1. Open a note that has markdown enabled
  2. tap on the markdown button
  • confirm you can see the markdown and can still see the toolbar buttons

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

RELEASE-NOTES.txt was updated in 74f0d3 with:

Fixed issue where toolbar buttons couldn't be seen while viewing markdown

@charliescheer charliescheer added the [feature] markdown Anything relating to markdown label May 14, 2024
@charliescheer charliescheer added this to the 2.21 milestone May 14, 2024
@charliescheer charliescheer self-assigned this May 14, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@charliescheer charliescheer merged commit 413e4f3 into trunk May 16, 2024
8 of 11 checks passed
@charliescheer charliescheer deleted the charlie/toolbar-buttons-invisible-in-markdown branch May 16, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] markdown Anything relating to markdown
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants