Add intents extension code signing #1153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencertransier
added
the
tooling
spencertransier
commented
May 18, 2024
| @@ -14,6 +14,7 @@ INTERNAL_SCHEME = 'Simplenote' | |||
| APP_STORE_SCHEME = 'Simplenote-AppStore' | |||
| BUILD_FOLDER = 'build' | |||
| APP_STORE_BUNDLE_IDENTIFIER = 'com.automattic.SimplenoteMac' | |||
| APP_STORE_BUNDLE_IDENTIFIER_INTENTS = "#{APP_STORE_BUNDLE_IDENTIFIER}.Intents".freeze | |||
There was a problem hiding this comment.
Because there are only two bundle identifiers for SNMac, I decided to just keep it nice and simple instead of our more complicated set ups for the other apps with more identifiers.
crazytonyli
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Completes pdnsEh-1Fh-p2. This PR adds a bundle identifier for the Intents extension. I've added the identifier on the Apple developer portal and ran the command to generate the new provisioning profile. I also added a development provisioning profile to be downloaded through MC. l
Test
bundle exec fastlane app_store_code_signingbundle exec fastlane app_store_code_signing readonly:falseRelease
These changes do not require release notes.