Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Core Data #1157

Closed

Conversation

charliescheer
Copy link
Contributor

Fix

On the way to being able to fetch core data entities for the shortcuts, I noticed that the core data stack for SNMac was all setup in the app delegate. This is fine because we aren't sharing the database outside of the core app currently, but soon I will be fetching from the database to do shortcuts, at which point we will have duplication problems.

So here I am extracting the core data setup into it's own class so we can easily setup a core data stack when running shortcuts/intents.

Test

  1. Build Simplenote
  2. confirm that you can interact with core data objects in the app, so notes/tags/etc

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@charliescheer charliescheer added the [feature] shortcuts Anything related to Shortcuts label May 22, 2024
@charliescheer charliescheer added this to the 2.21 milestone May 22, 2024
@charliescheer charliescheer self-assigned this May 22, 2024
@charliescheer
Copy link
Contributor Author

I identified an issue with the signing certificates/intents extension and removed a duplicate target we no longer needed in another PR. These changes are more easily rebuilt on top of that branch then where they are currently. Gonna close this PR in favor of ones I will replace it with shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] shortcuts Anything related to Shortcuts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants