-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Core Data #1157
Closed
charliescheer
wants to merge
13
commits into
charlie/1145/new-note-intent
from
charlie/1145/open-note-intent
Closed
Refactor Core Data #1157
charliescheer
wants to merge
13
commits into
charlie/1145/new-note-intent
from
charlie/1145/open-note-intent
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension Added SimplenoteIntents extension to Simplenote Mac Project
I identified an issue with the signing certificates/intents extension and removed a duplicate target we no longer needed in another PR. These changes are more easily rebuilt on top of that branch then where they are currently. Gonna close this PR in favor of ones I will replace it with shortly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
On the way to being able to fetch core data entities for the shortcuts, I noticed that the core data stack for SNMac was all setup in the app delegate. This is fine because we aren't sharing the database outside of the core app currently, but soon I will be fetching from the database to do shortcuts, at which point we will have duplication problems.
So here I am extracting the core data setup into it's own class so we can easily setup a core data stack when running shortcuts/intents.
Test
Review
(Required) Add instructions for reviewers. For example:
Release