-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop beta target #1158
Drop beta target #1158
Conversation
Generated by 🚫 Danger |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Verified the app can be built + runs correctly
✅ Verified that unit tests are green
One minor note @charliescheer, we may wanna use a different Bundle Identifier for debug builds, so that we avoid conflicts if you've got installed the AppStore build.
cc @spencertransier would defintely know what's best!!
Super okay to address that in a follow up, though.
Fix
In the SNMac project we have maintained two targets, Simplenote and Simplenote-AppStore, and every file we added needed to be in both. This has been fine until we started adding extensions that needed to be embedded in a parent app. That was going to cause a lot of duplication. Also, the only reason for the second extension was to make pushing beta versions of the app possible. We have made changes to how we do beta apps that make this no longer needed.
To simplify the app I have dropped the extra target in this PR. There was also an intents extension that was broken (how I discovered this) so that was dropped as well. All in all in this PR I have:
Note that there were some signing issues preventing the renamed Appstore target and the testing target from running. So currently I have set their signing to a personal team and Mac developer. These will need to get fixed
Test
(Required) List the steps to test the behavior. For example:
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txt
if the changes should be included in release notes. Include details about updating the notes in this section. For example: