Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop beta target #1158

Merged
merged 15 commits into from
May 24, 2024
Merged

Drop beta target #1158

merged 15 commits into from
May 24, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

In the SNMac project we have maintained two targets, Simplenote and Simplenote-AppStore, and every file we added needed to be in both. This has been fine until we started adding extensions that needed to be embedded in a parent app. That was going to cause a lot of duplication. Also, the only reason for the second extension was to make pushing beta versions of the app possible. We have made changes to how we do beta apps that make this no longer needed.

To simplify the app I have dropped the extra target in this PR. There was also an intents extension that was broken (how I discovered this) so that was dropped as well. All in all in this PR I have:

  1. Removed the broken intents extension
  2. removed the Simplenote target and build scheme
  3. Renamed the Simplenote-AppStore target and build scheme to Simplenote
  4. Updated the app icon so the beta icon will appear for debug builds
  5. Updated the testing target so that it will run on the renamed AppStore target
  6. Updated the fastfile to point to the correct target

Note that there were some signing issues preventing the renamed Appstore target and the testing target from running. So currently I have set their signing to a personal team and Mac developer. These will need to get fixed

Test

(Required) List the steps to test the behavior. For example:

  • Confirm that you can build the app with the new scheme
  • Run the tests and confirm they are all green
  • Confirm when you run the app you get the beta icon

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the debt Technical debt. label May 23, 2024
@charliescheer charliescheer added this to the 2.21 milestone May 23, 2024
@charliescheer charliescheer self-assigned this May 23, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Verified the app can be built + runs correctly
✅ Verified that unit tests are green

One minor note @charliescheer, we may wanna use a different Bundle Identifier for debug builds, so that we avoid conflicts if you've got installed the AppStore build.

cc @spencertransier would defintely know what's best!!

image

Super okay to address that in a follow up, though.

:shipit:

@charliescheer charliescheer merged commit fbd84b9 into trunk May 24, 2024
8 checks passed
@charliescheer charliescheer deleted the charlie/drop-beta-target branch May 24, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants