Shortcuts: Add open new note intent #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
jleandroperez
approved these changes
May 27, 2024
when ready!| @@ -8,8 +8,12 @@ | |||
| <dict> | |||
| <key>IntentsRestrictedWhileLocked</key> | |||
| <array/> | |||
| <key>IntentsSupported</key> | |||
| <key>IntentsRestrictedWhileProtectedDataUnavailable</key> | |||
|
This is GTG, just waiting on the PR that this relies on |
jleandroperez
approved these changes
May 29, 2024
|
|
||
| switch type { | ||
| case .newNoteShortcut: | ||
| SimplenoteAppDelegate.shared().noteEditorViewController.createNote(from: nil) |
There was a problem hiding this comment.
You can drop SimplenoteAppDelegate.shared() (because that should be self)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
So the very first shortcut to add is one that simply opens Simplenote and creates a new note. This is a basic proof of concept that the intents and shortcut handling works.
So in this PR you can create a shortcut "Open New Note" that will launch Simplenote and then create a new note.
Relies on #1159
Test
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txtif the changes should be included in release notes. Include details about updating the notes in this section. For example: