Shortcuts: Open Note #1163
Merged
Shortcuts: Open Note #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…5/open-note-intent-mk4
Generated by 🚫 Danger |
| @@ -0,0 +1,61 @@ | |||
| // This file contains the required class structure to be able to fetch and use core data files in widgets and intents | |||
There was a problem hiding this comment.
Nipticky: Filename should probably be Note+Intents ?
Base automatically changed from
charlie/migrate-database-to-group-container
to
trunk
May 31, 2024 17:28
roundhill
approved these changes
May 31, 2024
|
Good idea, TY. Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Okay, so back on track after a bunch of setup PRs. What we have here is the ability to open a note from a shortcut. That should be fairly simple, but there were a lot of core technologies that needed to be added to do this. So sorry but this PR is a little long. One the plus side several hundred lines of it are all xml files that are auto generated and shouldn't need much review.
Anyways, so the shortcut that I have added here allows you to specify or search for a note and then open it in Simplenote. Straight forward, but it is defining some of the core tech we will need for more advanced shortcuts.
Moves forward: #1145
relies on #1162
Test
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txtif the changes should be included in release notes. Include details about updating the notes in this section. For example: