Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added swiftlint warnings to appear in xcode #1164

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

charliescheer
Copy link
Contributor

Fix

I keep creating linting errors on my recent PRs because Xcode does some things by default that the linter doesn't like. It was bugging me.... so I updated the project build settings to run and show SwiftLint errors in the project when building SNMac.

quality of life improvement for me.

Test

  1. Open any swift file in SNMac and add a few extra lines in the middle somewhere.
  2. Build the app and confirm that you see linting errors

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the tooling Related to anything that supports the building & maintaining of the project. label May 29, 2024
@charliescheer charliescheer added this to the 2.21 milestone May 29, 2024
@charliescheer charliescheer self-assigned this May 29, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!!

:shipit:

@charliescheer charliescheer merged commit 44f56b2 into trunk May 30, 2024
8 of 11 checks passed
@charliescheer charliescheer deleted the update-Swiftlint branch May 30, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants