Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcuts: copy note content #1166

Merged
merged 4 commits into from
Jun 3, 2024
Merged

Shortcuts: copy note content #1166

merged 4 commits into from
Jun 3, 2024

Conversation

charliescheer
Copy link
Contributor

@charliescheer charliescheer commented May 29, 2024 •
edited
Loading

Fix

So one of the things that would be nice with shortcuts is to be able to get the content out of a note so you can apply it to another shortcut. In this PR I have done that. On it's own this shortcut isn't very useful, but if you connect it to another intent like copy to clipboard it becomes quite useful.

Test

  1. Run the branch and then open the shortcuts app. Create a new shortcut and look for Simplenote in the apps
  2. Add Copy Content From Note. Select a note
  3. search in the shortcuts sidebar for clipboard. Add "Copy To Clipboard
  4. run the shortcut.
  5. Go to another text app and paste. Confirm that the content from your note appears.

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@charliescheer charliescheer self-assigned this May 31, 2024
@charliescheer charliescheer added [feature] shortcuts Anything related to Shortcuts labels May 31, 2024
@charliescheer charliescheer modified the milestone: 2.21 May 31, 2024
@charliescheer charliescheer marked this pull request as ready for review May 31, 2024 20:38
jleandroperez
jleandroperez approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works exactly as advertised!!

:shipit:

jleandroperez
jleandroperez approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jleandroperez
Copy link
Contributor

Huh Github got super stuck, sorry about the noise!! 😆

@charliescheer charliescheer merged commit a3d8a53 into trunk Jun 3, 2024
16 checks passed
@charliescheer charliescheer deleted the charlie/1145/copy-note-content branch June 3, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleandroperez jleandroperez jleandroperez approved these changes

@roundhill roundhill Awaiting requested review from roundhill

Assignees

@charliescheer charliescheer

Labels
[feature] shortcuts Anything related to Shortcuts
Projects
None yet
Milestone
2.21 ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@charliescheer @jleandroperez