Shortcut: Append to note #1170
Merged
Shortcut: Append to note #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@charliescheer sending you a few notes!! only important one is related to the entitlements.
TY!!
IntentsExtension/Support Files/IntentsExtensionDebug.entitlements
Outdated
Show resolved
Hide resolved
| @@ -10,4 +10,7 @@ import Foundation | |||
|
|
|||
| struct IntentsConstants { | |||
| static let noteIdentifierKey = "OpenNoteIntentHandlerIdentifierKey" | |||
| static let extensionGroupName = Bundle.main.sharedGroupDomain | |||
| static let simperiumAppID = "chalk-bump-f49" | |||
There was a problem hiding this comment.
This should probably come from SimplenoteConstants.simperiumAppID
Please make sure that file doesn't get uploaded!
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
One of the most likely and useful functions we could add to Simplenote shortcuts is the ability to append to a note. So in this PR I have done so.
You can setup a shortcut to append a specific content to any note, or you can get the note from another shortcut intent.
The append intent uses the simperium api so the server can handle any diffing or sync that needs to happen and the main app does not need to be open for the shortcut to work and then sync.
relies on #1169
Test
Review
(Required) Add instructions for reviewers. For example:
Release