Work around tests hanging in #1167 and #1168

[mokagio]

Fix

The unit tests hang making the CI build time out in both #1167 and #1168.

I have not investigated what the cause might be, but the fact that they behave like that is note worthy.

The workaround is to run the tests sequentially rather than in parallel.

This was done by migrating to a Test Plan first, just to keep the setup modern.

I also removed some redundant CODE_SIGN_IDENTITY definitions, but that was an unrelated tidy up that I just thought I'd chunk in here.

Also, see note below about the commits in this PR.

Test

See green CI.

Also notice how bundle exec test hangs locally on the other PRs but succeeds here.

Review

Only one developer and required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

[mokagio]

🤔 I don't know why GitHub shows some of Charlies commit in the list, despite me having git reset --hard origin/trunk, cherry picked my commits only, then force pushed.

Maybe it's a GitHub cache thing?

My local git log:

---

Update: That remains the case even after having merged the latest trunk into #1167. Maybe that's got something to do with a rebase somewhere along the way?

[charliescheer]

Thanks for looking into this @mokagio I have been digging into it and it seems that SNMac isn't the only Mac app out there having this issue. I haven't been able to identify what is causing the issue, but it seems that the applications that are launched as the hosting application for the tests never close and when they don't close the testing process never "completes" I am gonna move forward with the workaround for now so that the shortcuts project can move forward/complete. I will continue to dig into what is happening with the Mac unit tests later

#1173

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[charliescheer]

I merged the branch this came off of and that fixed the weird extra commits.

This looks good to me and the CI is passing.

[mokagio]

Thanks @charliescheer for investigating. We don't have many macOS-native apps but the fact that there might be a problem with parallel tests at the toolchain level is something good to keep in mind.

Hopefully you'll have a chance to keep looking and find a fix 🤞