Add Base.xcconfig
and push most code signing settings there
#1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
This was prompted by some changes in the app identifiers (plural because we have one for release and one for debug) that required regenerating the provisioning profiles.
Internal ref pdnsEh-1Kz-p2
Adds a
Base.xcconfig
file and moves code signing settings there, so they are DRY and we don't need to deal with Xcode adding many lines to the project file every time we tweak them.The only setting that stayed in the project itself (i.e. we'd need to use the Build Settings GUI to modify it) is
PROVISIONING_PROFILE_SPECIFIER
because this is a per-target setting and we don't have that level of granularity in thexcconfig
sTest
You should be able to run a development build successfully after having downloaded a new development bundle from our Mission Control (Automatticians only).
I run a build locally in release mode to verify that mode builds, too.
Review
Only one developer or infra engineer required to review these changes, but anyone can perform the review.
Release
These changes do not require release notes.