Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Base.xcconfig and push most code signing settings there #1185

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Jul 2, 2024

Fix

This was prompted by some changes in the app identifiers (plural because we have one for release and one for debug) that required regenerating the provisioning profiles.

Internal ref pdnsEh-1Kz-p2

Adds a Base.xcconfig file and moves code signing settings there, so they are DRY and we don't need to deal with Xcode adding many lines to the project file every time we tweak them.

The only setting that stayed in the project itself (i.e. we'd need to use the Build Settings GUI to modify it) is PROVISIONING_PROFILE_SPECIFIER because this is a per-target setting and we don't have that level of granularity in the xcconfigs

Test

You should be able to run a development build successfully after having downloaded a new development bundle from our Mission Control (Automatticians only).

I run a build locally in release mode to verify that mode builds, too.
image

Review

Only one developer or infra engineer required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@mokagio mokagio marked this pull request as ready for review July 2, 2024 05:51
@mokagio mokagio requested review from charliescheer, jleandroperez and a team July 2, 2024 05:51
@mokagio mokagio added the tooling Related to anything that supports the building & maintaining of the project. label Jul 2, 2024
@mokagio mokagio added this to the 2.21 milestone Jul 2, 2024
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code changes / diff and LGTM, thought disclaimer that I haven't tested it in Xcode; I'll let a SN dev check it works as expected with their setup (eg even if they don't have release certs or ASC account in their Xcode like we AppsInfra might have)

The only setting that stayed in the project itself […] is PROVISIONING_PROFILE_SPECIFIER because this is a per-target setting and we don't have that level of granularity in the xcconfigs

Could be worth adding a // comment in the .xcconfig to mention that? (until we have time to create per-target xcconfig files in the future to solve that properly 😛)

@mokagio mokagio merged commit e90db2f into trunk Jul 31, 2024
8 checks passed
@mokagio mokagio deleted the mokagio/code-sign-setting-xcconfig branch July 31, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tooling Related to anything that supports the building & maintaining of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants