Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magic Links: Adjusting Copy #1189

Merged
merged 3 commits into from
Jul 17, 2024
Merged

Magic Links: Adjusting Copy #1189

merged 3 commits into from
Jul 17, 2024

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jul 11, 2024 •
edited by charliescheer
Loading

Fix

In this PR we're adjusting the copy of the "Invalid Link" UI, along with adding tracks events for Magic Link Auth Failure.

Test

  1. Paste this into iMessage (or any other messaging app you've got in your mac!!): https://app.simplenote.com/login?email=eW91cmVtYWlsQGxhbGFsYS5jb20==&auth_code=A000
  2. Click on the link
  • Verify Simplenote macOS ends up in the foreground
  • Verify that you get a UI indicating that the link is no longer valid
  • Verify that the changes make sense!

Screenshots

Release

These changes do not require release notes.

@jleandroperez jleandroperez added the enhancement Improve existing functionality. label Jul 11, 2024
@jleandroperez jleandroperez added this to the 2.21 milestone Jul 11, 2024
@jleandroperez jleandroperez self-assigned this Jul 11, 2024
@jleandroperez jleandroperez marked this pull request as ready for review July 11, 2024 18:29
roundhill
roundhill approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@roundhill roundhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

Base automatically changed from lantean/1187-updates-magic-link-endpoints to trunk July 17, 2024 13:10
@jleandroperez
Copy link
Contributor Author

Thank you both gentleman!!

@jleandroperez jleandroperez merged commit 70a895a into trunk Jul 17, 2024
9 checks passed
@jleandroperez jleandroperez deleted the lantean/adjusting-copy branch July 17, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliescheer charliescheer charliescheer approved these changes

@roundhill roundhill roundhill approved these changes

Assignees

@jleandroperez jleandroperez

Labels
enhancement Improve existing functionality.
Projects
None yet
Milestone
2.21 ❄️
Development

Successfully merging this pull request may close these issues.
3 participants
@jleandroperez @roundhill @charliescheer