Passkeys: Passkey authentication #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliescheer
changed the base branch from
trunk
to
charlie/passkey-registration
jleandroperez
approved these changes
Jul 17, 2024
| @@ -118,7 +135,7 @@ extension AuthenticationMode { | |||
| secondaryActionSelector: nil, | |||
| switchActionText: SignupStrings.switchAction, | |||
| switchActionTip: SignupStrings.switchTip, | |||
| switchTargetMode: { .loginWithMagicLink }, | |||
| switchTargetMode: { .loginWithPasskeys }, | |||
There was a problem hiding this comment.
Not sure if the default should be Passkeys, but good to leave for now!
Base automatically changed from
charlie/passkey-registration
to
feature/passkeys
July 17, 2024 19:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
So the next step in setting up passkeys on SN is authenticating with passkeys on Mac. So in this PR I have done that.
Note that because we are reworking the auth UI, I have decided to take over the UI for
login with emailthat was recently added and reuse it for my purposes. That is a temporary change since we are using a feature branch and it should be redone to work in the new UI before merging into trunk.Test
(Required) List the steps to test the behavior. For example:
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txtif the changes should be included in release notes. Include details about updating the notes in this section. For example: