Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Links: UI Updates Mk1 #1194

Merged
merged 3 commits into from
Jul 24, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

This is the first step in reshaping the SNMac authentication to meet the new designs using magic links as the primary mode of authentication.

signup view login with email

In this PR I have done the following:

  • Removed the switch mode button/view/actions
  • changed the Sign in view -> login view button to use the secondary button as it's trigger
  • refactored the ui for the sign in with WP button to match the design on iOS

What is not done here:

  • solve the sizing problem when hitting the back button on the navigation controller
  • Adding the next view where you can code auth or password auth
  • refactor authentication mode to be more generic
    These changes will be coming in the next PR

Test

  1. Launch SNMac, tap on the Login button and confirm the login with email view appears
  2. click on the login with Wordpress button and confirm that still works
  3. tap on the continue with password button and confirm the password appears
  4. Attempt login with email, confirm that works
  5. attempt login with password, confirm that works

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

(Required) Add a concise statement to RELEASE-NOTES.txt if the changes should be included in release notes. Include details about updating the notes in this section. For example:

These changes do not require release notes.

@charliescheer charliescheer added the [feature] login Anything relating to login label Jul 22, 2024
@charliescheer charliescheer self-assigned this Jul 22, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@roundhill
Copy link
Contributor

There's a bug I noticed that can be fixed in the follow-up PRs:

  1. Ensure you are signed out.
  2. Click a used magic link.
  3. The app opens to a view "Link no longer valid". Click Accept
  4. Now click Log in. Nothing happens!

@charliescheer charliescheer changed the base branch from trunk to feature/1187-magic-links July 24, 2024 16:23
@charliescheer charliescheer merged commit 7294414 into feature/1187-magic-links Jul 24, 2024
9 of 10 checks passed
@charliescheer charliescheer deleted the charlie/magic-link-ui branch July 24, 2024 16:24
@charliescheer charliescheer added this to the 2.21 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] login Anything relating to login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants