Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magic Links: Refactor Authentication Mode to handle auth view definitions #1195

Merged
merged 11 commits into from
Jul 24, 2024

Conversation

charliescheer
Copy link
Contributor

Fix

Primarily this PR doesn't do much that is visible, but it is laying the ground work to continuing updating the auth views to the new designs and layouts, so we can add magic links.

So in this PR I have:

  • Added defining the buttons on different views using an action descriptor struct
  • Updated the existing views to use the new action descriptor structs
  • dropped existing primary/secondary/wordpress properties and definitions from Auth mode

This shouldn't look too much different from the current state of the auth views, but because so many things have moved around here we should confirm that it all still works.

Test

  1. Launch Simplenote Mac
  2. Confirm that the launch screen now has no fields on it and looks more like the iOS launch screen
  3. Tap on sign up and confirm that the screen that appears is for signup. Test that you can create an account
  4. Tap on login and confirm you are given the option to login with email. Test that login still works
  5. Confirm on the login screen that you can tap on the secondary button to reveal the password field. Confirm you can login with a password
  6. Confirm on the login screen that the Wordpress SSO button is there and that if you tap on it the Wordpress sign on appears in your browser

Review

(Required) Add instructions for reviewers. For example:

Only one developer is required to review these changes, but anyone can perform the review.

Release

These changes do not require release notes.

@charliescheer charliescheer added the [feature] login Anything relating to login label Jul 24, 2024
@charliescheer charliescheer self-assigned this Jul 24, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@charliescheer charliescheer added this to the 2.21 milestone Jul 24, 2024
Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!! For the record, few details in here, which have been already fixed in the follow up PR, so let's move this one along!!

:shipit:

@charliescheer charliescheer merged commit aa04da5 into feature/1187-magic-links Jul 24, 2024
9 of 10 checks passed
@charliescheer charliescheer deleted the charlie/magic-links-ui-mk3 branch July 24, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[feature] login Anything relating to login
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants