-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Magic links: Tweaks and updates #1198
Merged
charliescheer
merged 8 commits into
feature/1187-magic-links
from
charlie/magic-links-mk5
Jul 26, 2024
Merged
Magic links: Tweaks and updates #1198
charliescheer
merged 8 commits into
feature/1187-magic-links
from
charlie/magic-links-mk5
Jul 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
15 tasks
jleandroperez
approved these changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ All test scenarios are green
Nice work!!
Love @roundhill attention to detail, I've stared at that screen all day, and didn't notice 🤦 !! |
@charliescheer the actual copy from iOS is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Magic link sign in on SNMac is almost there. After the last few updates we did some testing and have identified a few things that needed to be fixed. I have fixed many of those things in this PR. The list of changes fixed here:
-On Invalid Token UI, when you hit the back button the buttons on the onboarding view don't respond
-Enter Code TextField should probably be readable (since it's easy to miss, and it expires quickly, anyways)
-Going Back from the Enter Code UI results in the "Enter Email" UI, with your email highlighted
-Enter password button's textColor doesn't match the border
-Enter Password UI needs a header, too, with the account's email (recently added in iOS).
Test
####Login Flow####
####Invalid Code####
Review
(Required) Add instructions for reviewers. For example:
Release
(Required) Add a concise statement to
RELEASE-NOTES.txt
if the changes should be included in release notes. Include details about updating the notes in this section. For example: