Error Handling Upgrades #1200
Merged
Error Handling Upgrades #1200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleandroperez
added
debt
jleandroperez
commented
Jul 25, 2024
| - (void)showAuthenticationErrorForCode:(NSInteger)responseCode responseString:(NSString *)responseString { | ||
| switch (responseCode) { | ||
| case 409: | ||
| [self showAuthenticationError:NSLocalizedString(@"That email is already being used", @"Error when address is in use")]; |
There was a problem hiding this comment.
For security reasons, statusCode 409 has been phased out, few years ago
Base automatically changed from
lantean/wiring-simplenote-endpoints-spm
to
feature/1187-magic-links
July 26, 2024 17:02
|
Thank youuuu |
jleandroperez
merged commit e23dea3
into
feature/1187-magic-links
16 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
In this PR we're bringing
AuthenticationErrorfrom iOS, and simplifying, a bit, our Authentication Error Handlers.Test
Important: We'll improve on the
requestNotFounderror (code expired) flow in a follow up. I'll touch base with Sly, and align both iOS and macOS.Release