Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AuthenticationMode: RateLimiting Fallback #1203

Merged
merged 1 commit into from
Jul 26, 2024
Merged

AuthenticationMode: RateLimiting Fallback #1203

merged 1 commit into from
Jul 26, 2024

Conversation

jleandroperez
Copy link
Contributor

@jleandroperez jleandroperez commented Jul 26, 2024 •
edited by charliescheer
Loading

Fix

In this PR we're building "special" handling whenever the Request Login Code endpoint returns 429.

Test

  1. Fresh install Simplenote macOS
  2. Click on Log in
  3. Enter your email and click Log in with email
  4. Click back, and click on Log in with email about 4x times
  • Verify that eventually you get rate limited
  • Verify that you get sent straight to the Enter Password UI, whenever you're rate limited

Release

These changes do not require release notes.

@jleandroperez jleandroperez added the [feature] login Anything relating to login label Jul 26, 2024
@jleandroperez jleandroperez added this to the 2.21 milestone Jul 26, 2024
@jleandroperez jleandroperez self-assigned this Jul 26, 2024
@jleandroperez jleandroperez marked this pull request as ready for review July 26, 2024 18:48
Base automatically changed from lantean/1187-debt-fixes to feature/1187-magic-links July 26, 2024 19:48
charliescheer
charliescheer approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@charliescheer charliescheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works well

@jleandroperez
Copy link
Contributor Author

Thank youuuu!!

@jleandroperez jleandroperez merged commit a31ea9e into feature/1187-magic-links Jul 26, 2024
12 of 15 checks passed
@jleandroperez jleandroperez deleted the lantean/1187-rate-limiting-fallback branch July 26, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliescheer charliescheer charliescheer approved these changes

Assignees

@jleandroperez jleandroperez

Labels
[feature] login Anything relating to login
Projects
None yet
Milestone
2.21 ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@jleandroperez @charliescheer