Add VIP_GO_APP_ID to telemetry event data

[alecgeatches]

Description

This PR extends the recent Tracks telemetry work (#5869, #5921) to include VIP app IDs in a separate field on events. We already utilize app IDs for user identification:

vip-go-mu-plugins/telemetry/tracks/class-tracks-event.php

Lines 206 to 214 in 7508ea9

	if ( defined( 'VIP_GO_APP_ID' ) ) {
	$app_id = constant( 'VIP_GO_APP_ID' );
	if ( is_integer( $app_id ) && $app_id > 0 ) {
	$event->_ui = sprintf( '%s_%s', $app_id, $wp_user->ID );
	$event->_ut = 'vip_go_app_wp_user';
	return $event;
	}
	}

This tracks userids with values in the format {{site_id}}_{{wp_user_id}}. This is less useful for tracking per-app events, since we'd require parsing and preprocessing event data. This PR serves to explicitly track app IDs in a separate data point to make filtering easier. Note that we already track the app environment (e.g. local/develop) as well as organization ID, so this fits right in.

Changelog Description

Changed

• Added VIP_GO_APP_ID to Tracks telemetry events

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
• This change works and has been tested on a sandbox.
• This change has relevant unit tests (if applicable).
• This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

• VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

Run unit tests:

./bin/test.sh --filter Tracks_Event_Test

[alecgeatches]

I branched these changes from #5921, so probably best to merge those first.

[mjangda]

We already utilize app IDs for user identification

Should we just remove that block? On VIP, the user id should be set based on the hashed email (the VIP_TELEMETRY_SALT block above).

[mjangda]

Left some suggestions on this.

It would be nice to cleanup the other props as well (i.e. change any references of vipgo_ to vip_ (e.g. vipgo_env), although I realize that is increasing the scope of this PR :)

Separately, what do you think about adding the home or site URL as a prop? (vip_home_url). The ID is helpful, but the URL would make sorting through data easier.

[mjangda]

Similar to the app change, let's rename this:

Suggested change

	$event->vipgo_org = $org_id;
	$event->vip_org_id = $org_id;

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.29%. Comparing base (4f8794e) to head (1a1c445).
Report is 92 commits behind head on develop.

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #5922      +/-   ##
=============================================
+ Coverage      30.26%   30.29%   +0.03%     
- Complexity      4812     4815       +3     
=============================================
  Files            287      287              
  Lines          20707    20699       -8     
=============================================
+ Hits            6267     6271       +4     
+ Misses         14440    14428      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sanmai]

It sounds like we addressed all @mjangda's suggestions.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sanmai]

WP nightly tests are broken, probably unrelated to this PR.

[github-actions]

This pull request has been marked stale because it has been open for 60 days with no activity. If there is no activity within 7 days, it will be closed.

This is an automation to keep pull requests manageable and actionable and is not a comment on the quality of this pull request nor on the work done so far. Closed PRs are still valuable to the project and their branches are preserved.

[alecgeatches]

It appears these changes were wrapped into the work in #5990 and #5966, see discussion. Closing!