Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix last changed date after dynamic bulk index #6015

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

sathyapulse
Copy link
Contributor

@sathyapulse sathyapulse commented Nov 26, 2024

Description

The commit ecfb7bddc877d2326659cf8d03dcf3ddfb7faa55 changed the bulk index method from bulk_index to bulk_index_dynamically. The method triggers a different hook called ep_after_bulk_index_dynamically after the bulk index.

The last changed date was not updated after the bulk index because of the hook change. This commit adds the
ep_after_bulk_index_dynamically hook to update the last changed date so that it fetches the latest document from ES after it is indexed.

Changelog Description

Added

Removed

Fixed

Changed

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

The commit ecfb7bddc877d2326659cf8d03dcf3ddfb7faa55 changed the bulk index
method from bulk_index to bulk_index_dynamically. The method triggers a
different hook called ep_after_bulk_index_dynamically after the bulk index.

The last changed date was not updated after the bulk index
because of the hook change. This commit adds the
ep_after_bulk_index_dynamically hook to update the last changed date.
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.53%. Comparing base (cb8e520) to head (b94a7d7).
Report is 22 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6015      +/-   ##
=============================================
+ Coverage      30.51%   30.53%   +0.02%     
  Complexity      4811     4811              
=============================================
  Files            289      289              
  Lines          21173    21163      -10     
=============================================
+ Hits            6461     6463       +2     
+ Misses         14712    14700      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rebeccahum rebeccahum marked this pull request as ready for review November 26, 2024 14:42
@rebeccahum rebeccahum requested a review from a team as a code owner November 26, 2024 14:42
@rebeccahum rebeccahum merged commit 69170c4 into develop Nov 26, 2024
34 of 35 checks passed
@rebeccahum rebeccahum deleted the fix/bump-last-changed-after-bulk-index branch November 26, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants