Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enterprise Search: Add filter ep_disable_query_logging and do not facet feed queries #6030

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

rebeccahum
Copy link
Contributor

Description

Pulls in Automattic/ElasticPress#217 and Automattic/ElasticPress#209

Changelog Description

Added

  • Enterprise Search: Add new filter ep_disable_query_logging

Changed

  • Enterprise Search: Do not facet feed queries to prevent duplicate posts on display

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review December 3, 2024 18:05
@rebeccahum rebeccahum requested a review from a team as a code owner December 3, 2024 18:05
Copy link

sonarqubecloud bot commented Dec 3, 2024

@rebeccahum rebeccahum merged commit 7fbda41 into develop Dec 3, 2024
35 checks passed
@rebeccahum rebeccahum deleted the update/elasticpress branch December 3, 2024 18:19
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.53%. Comparing base (92ea13a) to head (b2b157d).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6030      +/-   ##
=============================================
+ Coverage      30.52%   30.53%   +0.01%     
  Complexity      4811     4811              
=============================================
  Files            289      289              
  Lines          21175    21163      -12     
=============================================
  Hits            6463     6463              
+ Misses         14712    14700      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants