Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack: Display correct Jetpack version in plugins list UI #6043

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Dec 10, 2024

Description

For non-pinned versions, we load a default JP version that is in accordance with the minimum supported WP version. This will fix the UI to display it correctly.

Changelog Description

Fixed

  • Jetpack: Correct version will display for non-pinned default loading in Plugins listing

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review December 10, 2024 16:03
@rebeccahum rebeccahum requested a review from a team as a code owner December 10, 2024 16:03
@rebeccahum rebeccahum force-pushed the display-jetpack-ui-version-plugins-list branch from 9cb7ac2 to 9198cd4 Compare December 10, 2024 16:04
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 30.53%. Comparing base (97c10f8) to head (3cb1115).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
vip-jetpack/vip-jetpack.php 0.00% 7 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #6043      +/-   ##
=============================================
+ Coverage      30.51%   30.53%   +0.01%     
  Complexity      4811     4811              
=============================================
  Files            289      289              
  Lines          21177    21169       -8     
=============================================
  Hits            6463     6463              
+ Misses         14714    14706       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 10, 2024

@rebeccahum rebeccahum merged commit c82dc65 into develop Dec 10, 2024
35 of 36 checks passed
@rebeccahum rebeccahum deleted the display-jetpack-ui-version-plugins-list branch December 10, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants