Skip to content

Commit

Permalink
Merge branch 'develop' into improve-pmme-placement-shortcode
Browse files Browse the repository at this point in the history
  • Loading branch information
gpressutto5 authored Dec 19, 2024
2 parents 76db323 + 863519d commit 3b1238c
Show file tree
Hide file tree
Showing 41 changed files with 513 additions and 50 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: dev

Remove hooks from customer and token services to dedicated methods
4 changes: 4 additions & 0 deletions changelog/feat-9810-add-seller-message
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: add

Add seller_message to failed order notes
4 changes: 4 additions & 0 deletions changelog/fix-9114-level3-rounding
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: fix

Add a rounding entry to Level 3 data for rare cases where rounding errors break calculations.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Hide transaction fee on admin view order screen when transaction is not captured.
4 changes: 4 additions & 0 deletions changelog/fix-9987-filter-csv-disputes
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Fix filtering in async Disputes CSV export
4 changes: 4 additions & 0 deletions changelog/fix-9996-currency-conversion-fee-phrasing
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: fix

Use "currency conversion fee" instead "foreign exchange fee" in payment timeline and various other places.
5 changes: 5 additions & 0 deletions changelog/fix-tokenized-ece-product-bundles-totals
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Significance: patch
Type: fix
Comment: fix: tokenized ECE item compatibility w/ product bundles


4 changes: 4 additions & 0 deletions changelog/update-9919-embedded-components-width
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: update

Update Embedded Components and MOX to support custom width and paddings.
15 changes: 2 additions & 13 deletions client/data/disputes/hooks.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ import type {
} from 'wcpay/types/disputes';
import type { ApiError } from 'wcpay/types/errors';
import { STORE_NAME } from '../constants';
import { disputeAwaitingResponseStatuses } from 'wcpay/disputes/filters/config';

/**
* Returns the dispute object, error object, and loading state.
Expand Down Expand Up @@ -98,11 +97,6 @@ export const useDisputes = ( {
( select ) => {
const { getDisputes, isResolving } = select( STORE_NAME );

const search =
filter === 'awaiting_response'
? disputeAwaitingResponseStatuses
: undefined;

const query = {
paged: Number.isNaN( parseInt( paged ?? '', 10 ) )
? '1'
Expand All @@ -119,7 +113,7 @@ export const useDisputes = ( {
dateBetween.sort( ( a, b ) =>
moment( a ).diff( moment( b ) )
),
search,
filter,
statusIs,
statusIsNot,
orderBy: orderBy || 'created',
Expand Down Expand Up @@ -163,11 +157,6 @@ export const useDisputesSummary = ( {
( select ) => {
const { getDisputesSummary, isResolving } = select( STORE_NAME );

const search =
filter === 'awaiting_response'
? disputeAwaitingResponseStatuses
: undefined;

const query = {
paged: Number.isNaN( parseInt( paged ?? '', 10 ) )
? '1'
Expand All @@ -180,7 +169,7 @@ export const useDisputesSummary = ( {
dateBefore,
dateAfter,
dateBetween,
search,
filter,
statusIs,
statusIsNot,
};
Expand Down
7 changes: 5 additions & 2 deletions client/data/disputes/resolvers.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
updateDisputesSummary,
updateErrorForDispute,
} from './actions';
import { disputeAwaitingResponseStatuses } from 'wcpay/disputes/filters/config';

const formatQueryFilters = ( query ) => ( {
user_email: query.userEmail,
Expand All @@ -31,7 +32,10 @@ const formatQueryFilters = ( query ) => ( {
formatDateValue( query.dateBetween[ 0 ] ),
formatDateValue( query.dateBetween[ 1 ], true ),
],
search: query.search,
search:
query.filter === 'awaiting_response'
? disputeAwaitingResponseStatuses
: query.search,
status_is: query.statusIs,
status_is_not: query.statusIsNot,
locale: query.locale,
Expand All @@ -42,7 +46,6 @@ export function getDisputesCSV( query ) {
`${ NAMESPACE }/disputes/download`,
formatQueryFilters( query )
);

return path;
}

Expand Down
2 changes: 2 additions & 0 deletions client/disputes/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,7 @@ export const DisputesList = (): JSX.Element => {
date_after: dateAfter,
date_between: dateBetween,
match,
filter,
status_is: statusIs,
status_is_not: statusIsNot,
} = getQuery();
Expand Down Expand Up @@ -407,6 +408,7 @@ export const DisputesList = (): JSX.Element => {
dateBefore,
dateBetween,
match,
filter,
statusIs,
statusIsNot,
} ),
Expand Down
8 changes: 5 additions & 3 deletions client/onboarding/style.scss
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,12 @@ body.wcpay-onboarding__body {
}

&__content {
max-width: 400px;
max-width: 615px;
width: 100%;

@media screen and ( min-width: $break-mobile ) {
width: 400px;
@media screen and ( max-width: $break-mobile ) {
width: 100%;
padding: 0 $gap;
}
}

Expand Down
4 changes: 2 additions & 2 deletions client/payment-details/timeline/map-events.js
Original file line number Diff line number Diff line change
Expand Up @@ -410,12 +410,12 @@ export const feeBreakdown = ( event ) => {
fixedRate !== 0
? __(
/* translators: %1$s% is the fee percentage and %2$s is the fixed rate */
'Foreign exchange fee: %1$s%% + %2$s',
'Currency conversion fee: %1$s%% + %2$s',
'woocommerce-payments'
)
: __(
/* translators: %1$s% is the fee percentage */
'Foreign exchange fee: %1$s%%',
'Currency conversion fee: %1$s%%',
'woocommerce-payments'
),
'additional-wcpay-subscription':
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ exports[`mapTimelineEvents single currency events formats captured events with f
International card fee: 1.5%
</li>
<li>
Foreign exchange fee: 2%
Currency conversion fee: 2%
</li>
<li>
Discount
Expand Down
Loading

0 comments on commit 3b1238c

Please sign in to comment.