Remove payouts rename notice overlay. (#10039)

Co-authored-by: Nagesh Pai <[email protected]>
Automattic · Jan 1, 2025 · 85865e8 · 85865e8
1 parent bacc8ed
commit 85865e8
Show file tree

Hide file tree

Showing 14 changed files with 4 additions and 297 deletions.
diff --git a/changelog/update-9704-remove-payouts-rename-overlay b/changelog/update-9704-remove-payouts-rename-overlay
@@ -0,0 +1,4 @@
+Significance: minor
+Type: update
+
+Remove the overlay that announces the rename from deposits to payouts.
diff --git a/client/deposits/details/index.tsx b/client/deposits/details/index.tsx
@@ -38,7 +38,6 @@ import {
 } from 'multi-currency/interface/functions';
 import { depositStatusLabels } from '../strings';
 import './style.scss';
-import { PayoutsRenameNotice } from '../rename-notice';
 import { formatDateTimeFromString } from 'wcpay/utils/date-time';
 import DateFormatNotice from 'wcpay/components/date-format-notice';
 
@@ -243,7 +242,6 @@ export const DepositDetails: React.FC< DepositDetailsProps > = ( {
 
 	return (
 		<Page>
-			<PayoutsRenameNotice />
 			<DateFormatNotice />
 			<TestModeNotice currentPage="deposits" isDetailsView={ true } />
 			<ErrorBoundary>

diff --git a/client/deposits/index.tsx b/client/deposits/index.tsx
@@ -17,7 +17,6 @@ import { __ } from '@wordpress/i18n';
 import { TestModeNotice } from 'components/test-mode-notice';
 import BannerNotice from 'components/banner-notice';
 import DepositSchedule from 'components/deposits-overview/deposit-schedule';
-import { PayoutsRenameNotice } from './rename-notice';
 import { useAllDepositsOverviews } from 'data';
 import { useSettings } from 'wcpay/data';
 import DepositsList from './list';
@@ -152,7 +151,6 @@ const DepositsPage: React.FC = () => {
 		<Page>
 			<DateFormatNotice />
 			<TestModeNotice currentPage="deposits" />
-			<PayoutsRenameNotice />
 			<NextDepositNotice />
 			<DepositFailureNotice />
 			<DepositsList />

diff --git a/client/deposits/rename-notice/header-image.svg b/client/deposits/rename-notice/header-image.svg
diff --git a/client/deposits/rename-notice/index.tsx b/client/deposits/rename-notice/index.tsx
diff --git a/client/deposits/rename-notice/style.scss b/client/deposits/rename-notice/style.scss
diff --git a/client/deposits/rename-notice/test/__snapshots__/index.tsx.snap b/client/deposits/rename-notice/test/__snapshots__/index.tsx.snap
diff --git a/client/deposits/rename-notice/test/index.tsx b/client/deposits/rename-notice/test/index.tsx
diff --git a/client/globals.d.ts b/client/globals.d.ts
@@ -89,7 +89,6 @@ declare global {
 		fraudProtection: {
 			isWelcomeTourDismissed?: boolean;
 		};
-		isPayoutsRenameNoticeDismissed: boolean;
 		progressiveOnboarding?: {
 			isEnabled: boolean;
 			isComplete: boolean;

diff --git a/client/overview/index.js b/client/overview/index.js
@@ -32,7 +32,6 @@ import { useDisputes, useGetSettings, useSettings } from 'data';
 import SandboxModeSwitchToLiveNotice from 'wcpay/components/sandbox-mode-switch-to-live-notice';
 import './style.scss';
 import BannerNotice from 'wcpay/components/banner-notice';
-import { PayoutsRenameNotice } from 'wcpay/deposits/rename-notice';
 import DateFormatNotice from 'wcpay/components/date-format-notice';
 
 const OverviewPageError = () => {
@@ -197,7 +196,6 @@ const OverviewPage = () => {
 			{ showConnectionSuccess && <ConnectionSuccessNotice /> }
 			{ ! accountRejected && ! accountUnderReview && (
 				<ErrorBoundary>
-					<PayoutsRenameNotice />
 					<Welcome />
 
 					{ showTaskList && (

diff --git a/client/overview/test/index.js b/client/overview/test/index.js
@@ -352,24 +352,4 @@ describe( 'Overview page', () => {
 
 		expect( query() ).not.toBeInTheDocument();
 	} );
-
-	it( 'shows payout rename notice if not yet dismissed', () => {
-		global.wcpaySettings.isPayoutsRenameNoticeDismissed = false;
-
-		render( <OverviewPage /> );
-
-		expect(
-			screen.queryByText( 'Deposits are now known as Payouts!' )
-		).toBeInTheDocument();
-	} );
-
-	it( 'does not display payout rename notice if already dismissed', () => {
-		global.wcpaySettings.isPayoutsRenameNoticeDismissed = true;
-
-		render( <OverviewPage /> );
-
-		expect(
-			screen.queryByText( 'Deposits are now known as Payouts!' )
-		).not.toBeInTheDocument();
-	} );
 } );
diff --git a/includes/admin/class-wc-payments-admin.php b/includes/admin/class-wc-payments-admin.php
@@ -959,7 +959,6 @@ private function get_js_settings(): array {
 			'fraudProtection'                    => [
 				'isWelcomeTourDismissed' => WC_Payments_Features::is_fraud_protection_welcome_tour_dismissed(),
 			],
-			'isPayoutsRenameNoticeDismissed'     => WC_Payments_Features::is_payouts_rename_notice_dismissed(),
 			'enabledPaymentMethods'              => $this->get_enabled_payment_method_ids(),
 			'progressiveOnboarding'              => $this->account->get_progressive_onboarding_details(),
 			'accountDefaultCurrency'             => $this->account->get_account_default_currency(),

diff --git a/includes/class-wc-payments-features.php b/includes/class-wc-payments-features.php
@@ -298,15 +298,6 @@ public static function is_fraud_protection_welcome_tour_dismissed(): bool {
 		return '1' === get_option( 'wcpay_fraud_protection_welcome_tour_dismissed', '0' );
 	}
 
-	/**
-	 * Checks whether the Payouts Rename Spotlight notice was dismissed.
-	 *
-	 * @return bool
-	 */
-	public static function is_payouts_rename_notice_dismissed(): bool {
-		return '1' === get_option( 'wcpay_payouts_rename_notice_dismissed', '0' );
-	}
-
 	/**
 	 * Checks whether the Stripe Billing feature is enabled.
 	 *

diff --git a/includes/class-wc-payments.php b/includes/class-wc-payments.php
@@ -1923,7 +1923,6 @@ public static function add_wcpay_options_to_woocommerce_permissions_list( $permi
 				'woocommerce_remind_me_later_todo_tasks',
 				'woocommerce_deleted_todo_tasks',
 				'wcpay_fraud_protection_welcome_tour_dismissed',
-				'wcpay_payouts_rename_notice_dismissed',
 				'wcpay_capability_request_dismissed_notices',
 				'wcpay_onboarding_eligibility_modal_dismissed',
 				'wcpay_next_deposit_notice_dismissed',