Add TS type assertion for disputes CSV export API response to fix type safety #10008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TypeScript type assertion to `apiFetch` call in disputes CSV export to: - Ensure type safety for `exported_disputes` response property - Add JSDoc documentation for the exported disputes count - Fix TypeScript error "Property 'exported_disputes' does not exist on type 'unknown'"
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.39 MB ℹ️ View Unchanged
|
shendy-a8c
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Looks good!
I thought the error comes from tsc. By the way, when running
tsc --noEmit client/disputes/index.tsx, I got:
error TS2688: Cannot find type definition file for 'wordpress__keycodes'.
The file is in the program because:
Entry point for implicit type library 'wordpress__keycodes'
error TS2688: Cannot find type definition file for 'wordpress__notices'.
The file is in the program because:
Entry point for implicit type library 'wordpress__notices'
error TS2688: Cannot find type definition file for 'wordpress__rich-text'.
The file is in the program because:
Entry point for implicit type library 'wordpress__rich-text'
But then I saw the error in my IDE.
With this PR branch, I don't see the error in my IDE anymore.
Code looks good as well.
Jinksi
deleted the
fix/10007-disputes-csv-export-response-type-assertion
branch
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10007
Changes proposed in this Pull Request
Add TypeScript type assertion to
apiFetchcall in disputes CSV export to:exported_disputesresponse propertyNote
This is purely a TypeScript type definition change and doesn't affect runtime behaviour or functionality.
Testing instructions
tsc --noEmit)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge