-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix blank Overview page when WC onboarding is disabled #10020
Fix blank Overview page when WC onboarding is disabled #10020
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +12 B (0%) Total Size: 1.39 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this, Vlad!
✅ The code changes look good and make sense.
✅ The testing instructions pass as outlined, and no blank page is observed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Code change looks good.
✅ Changelog explains the issue well.
✅ Manual testing worked as expected.
Fixes #9742
Changes proposed in this Pull Request
We are now more defensive about missing WC Admin onboarding data and avoid the JS error that leads to the blank Payments > Onboarding page.
Testing instructions
fix/9742-blank-overview-page-without-wc-features
feature branch.onboarding
andonboarding-tasks
features:npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge