Remove DateFormatNotice #10129
Merged
Remove DateFormatNotice #10129
+7
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: -323 B (0%) Total Size: 1.36 MB
ℹ️ View Unchanged
|
deepakpathania
approved these changes
Jan 13, 2025
Thanks for the review @deepakpathania. Yes, the commit 3794508 included additional changes, so a revert was not a good fit in this case. |
…e-dateformatnotice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10021
Warning
Release date is TBD. Do not merge until we have confirmation here
Changes proposed in this Pull Request
This pull request removes the
DateFormatNoticecomponent from various parts of the codebase, including its imports, usage, and associated styles. The changes are spread across multiple files and involve updating both the main code and test snapshots.Testing instructions
developbranch, navigate to WP Admin > Payments and make sure the date format notice is visible on any of the pages. Hint: you may need to remove thewcpay_date_format_notice_dismissedoption.npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge