Added currency code to fee breakdown when currency symbol is same #10138
+26
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.36 MB ℹ️ View Unchanged
|
mgascam
reviewed
Jan 13, 2025
There was a problem hiding this comment.
Code changes look good to me and tests well, but I found a CSS issue in my testing:
Firefox
Chrome
I am not sure if this is related to the changes in this PR, but I'd say it can be fixed by tweaking the CSS line-height, can you take a look?
I also noticed a JS test is failing, and added a comment about PHP tests.
There was a problem hiding this comment.
Should we add test cases to asses the composed fee string to tests/unit/test-class-wc-payments-captured-event-note.php?
There was a problem hiding this comment.
🤔 This is how it looks like on my end. I will dig a bit deeper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10006
Changes proposed in this Pull Request
This PR updates the fee breakdown in order notes to include the currency code when currencies with identical symbols are used. For example, both Canada and Mexico use the "$" symbol, which can cause confusion for merchants when multi-currency support is enabled. To address this, the currency code is now displayed alongside the symbol, ensuring that merchants can easily distinguish between currencies like CAD and MXN.
Testing Instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge