Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the conditional completed and additionalInfo attribute for dispute task. #4473

Merged
merged 3 commits into from
Jul 22, 2022

Conversation

shendy-a8c
Copy link
Contributor

@shendy-a8c shendy-a8c commented Jul 22, 2022

Changes proposed in this Pull Request

Addressing feedbacks from #4388, ie:

  1. Since dispute task list will only show if there is non-zero disputes needing response and it will not show if there is 0 disputes needing response, the task list is cannot be completed, so I removed the condition for completed and additionalInfo attribute.
  2. Better wording for changelog.

Testing instructions

I can't think of a way to test this changes as it's just a cleaner code.


  • Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Post merge

@shendy-a8c shendy-a8c changed the base branch from develop to fix/plural-disputes-task-list July 22, 2022 07:10
@shendy-a8c shendy-a8c requested a review from Jinksi July 22, 2022 07:12
@shendy-a8c shendy-a8c marked this pull request as ready for review July 22, 2022 07:12
Base automatically changed from fix/plural-disputes-task-list to develop July 22, 2022 07:24
Copy link
Member

@Jinksi Jinksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @shendy-a8c 💯

I smoke-tested this build with both 1 and 0 disputes and the task looks identical, as expected.

@shendy-a8c shendy-a8c force-pushed the fix/disputes-task-list-changes branch from 8a3245d to 0151943 Compare July 22, 2022 08:06
@shendy-a8c shendy-a8c merged commit 38b2ba5 into develop Jul 22, 2022
@shendy-a8c shendy-a8c deleted the fix/disputes-task-list-changes branch July 22, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants