-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RPP: Add order meta upon the AuthenticationRequired state #7540
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.43 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Manual test looks good.
✅ Code-wise looks good too though I have a nitpick comment.
Pre-approve!
Update: but make sure to address the Psalm error, and add a changelog entry.
b277785
to
5fad823
Compare
Fixes #7553
Changes proposed in this Pull Request
Introduce a new
update_order_from_intent_that_requires_action
method in the order service, and make sure it to call it before transitioning fromInitialState
toAuthenticationRequiredState
.Testing instructions
Check out with a 3DS card (*** 3184), and make sure that checkout worked, incl. order notes.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.