Add skeleton loading element to cart page page BNPL messaging #8607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.41 kB (0%) Total Size: 1.22 MB
ℹ️ View Unchanged
|
timur27
reviewed
Apr 10, 2024
There was a problem hiding this comment.
Great job @mdmoore 🎉 I just left one comment where I'd like us to try to reproduce the misaligned CSS which happened a few times for me. I'm happy to approve right after we quickly align on this, because I don't have any more threads to discuss.
timur27
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8606
Changes proposed in this Pull Request
This affects only shortcode cart. When the cart totals update, the BNPL Payment Method Messaging Element is removed by the core update of that section. This requires that it is remounted after the updated HTML is inserted to that section. The skeleton component bridges the loading gap between that insert and the remount of the PMME.
For context and demo, see: #8144 (comment)
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge