Fix Payment block error while editing the blocks checkout page. #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovide checks for when wc()->cart and country aren't available.
…present Also only show the PMME if the amount is > 0 and if the currentCountry is set.
brettshumaker
requested review from
a team and
gpressutto5
and removed request for
a team
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +13 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
frosso
approved these changes
May 8, 2024
Co-authored-by: Francesco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8676
Changes proposed in this Pull Request
This PR makes a few edits to make sure the PMME block has the info it needs to render in the block editor. Prior to this PR, the
wcBlocksCheckoutDataJS variable was added to the page only whenWC()->cartexisted - it does not exist in the block editor. This PR makes sure that this variable is always added and usesWC()->cartandWC()->customerfor the values when available, but falls back to defaults when it doesn't.This PR also conditionally checks for the existence of
window.wcBlocksCheckoutData?.storeCountrywhen setting thecurrentCountry. It also only displays the PMME when the amount is greater than0and when we have acurrentCountryset.Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge