Fix fatal errors when subscription classes are not available #8823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjrosa
changed the title
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
|
@wjrosa I'm just noticing this PR is still open. Since this change is in the WooPayments plugin, I'd suggest asking for a review from the teams that are more involved in it. I'd ask in Slack which team is the best one to assign as a reviewer. |
thanks, Danae! I will do some digging to find out 👀 |
frosso
approved these changes
Jul 16, 2024
lovo-h
pushed a commit
that referenced
this pull request
Aug 1, 2024
Co-authored-by: Wesley Rosa <[email protected]> Co-authored-by: Diego Curbelo <[email protected]> Co-authored-by: Francesco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Fixing fatal errors when subscription classes are not available
This PR fixes fatal errors thrown when subscription classes are not available. It includes a check for the existence of
store_has_active_wcpay_subscriptionsbefore calling it. Without it, the following fatal error is thrown:Testing instructions
exit;before the declaration ofWC_Subscriptionsdevelopit would throw the fatal error above)npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge