perf: unneeded WooPay scripts #8829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
frosso
requested review from
a team,
FangedParakeet and
brettshumaker
and removed request for
a team and
FangedParakeet
|
Size Change: 0 B Total Size: 1.26 MB ℹ️ View Unchanged
|
frosso
changed the title
frosso
changed the title
|
Thanks @brettshumaker - I'll be waiting for people's blessings in here before merging |
|
It looks like this PR has been merged with only the changelog entry. This is because the same changes were also implemented in #8644 , which has been merged first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes proposed in this Pull Request
The
client/checkout/woopay/index.jsscripts are used on checkout pages to render the "save user" section.I noticed these scripts are enqueued on every page, even product pages.
Together with these, more than half a dozen additional WC Blocks scripts are being enqueued.
Since we don't need to render them on non-checkout pages, let's ensure they are not enqueued.
Testing instructions
dist/woopay.jsfile enqueueddist/woopay.jsfile enqueuednpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge