Workaround for mismatch between Transaction Listing Report and Payment Activity Overview screens due to timezone. #9073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The Payment Overview widget accepts dates in merchant timezone, while Transactions Listing screen expects UTC.
jessy-p
changed the title
jessy-p
changed the title
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +15 B (0%) Total Size: 1.27 MB
ℹ️ View Unchanged
|
|
Closing as we will be taking a more holistic approach for this issue with timezones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for #9064
The Payment Activity widget uses the dates from the date filtering input as merchant timezone. But when these dates are passed to the existing Transaction Listing screens (navigated from the View Report links), they are assumed to be in UTC.
This causes mismatch between the widget and the linked reports, pdjTHR-3N2-p2#comment-5417
The permanent fix could be to fix all Report screens to use the merchant timezone #9064, but we might workaround this by converting and passing the dates on the `View Report' link, as done in this PR.
Changes proposed in this Pull Request
In the Payment Activity widget, convert the merchant timezone dates into UTC before passing them to the Transaction Reporting screen.
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge