Pass Blocks checkout appearance on init WooPay #9075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +37.5 kB (+3%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
hsingyuc
requested review from
a team and
alefesouza
and removed request for
a team
hsingyuc
force-pushed
the
add/pass-blocks-checkout-appearance-on-init-woopay
branch
from
c93bf51 to
acd2af3
Compare
hsingyuc
force-pushed
the
add/pass-blocks-checkout-appearance-on-init-woopay
branch
from
8ef4604 to
3fe78b8
Compare
|
@hsingyuc the appearance data is not being sent when clicking the WooPay button on blocks checkout page, only works on the email field redirect, is that expected? |
Do you mean you log
@alefesouza When click the WooPay button on the Blocks checkout page, it should work as below: Screen.Recording.2024-07-15.at.3.43.33.PM.mov |
alefesouza
requested changes
Jul 16, 2024
There was a problem hiding this comment.
@hsingyuc on your video for some reason the express checkout button is using the fallback instead of redirect to WooPay without opening the popup, could you take a look? On the following video the styles are being applied when using the email redirect but not when clicking the button without the fallback:
Screen.Recording.2024-07-15.at.9.50.32.PM.mov
hsingyuc
force-pushed
the
add/pass-blocks-checkout-appearance-on-init-woopay
branch
from
2618344 to
464ade4
Compare
|
@alefesouza I'm having hard time to hit first-party auth but I pass blocks checkout appearance on first-party auth, can you test it for me? Thanks! |
hsingyuc
force-pushed
the
add/pass-blocks-checkout-appearance-on-init-woopay
branch
from
32bd0d3 to
bf2749f
Compare
|
@alefesouza I got first-party auth working, added a fix when on NUX and updated the test instructions. Thank you! |
6 tasks
lovo-h
pushed a commit
that referenced
this pull request
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR is part of Spike – Global Themes Support proof of concept.
We reuse
getAppearanceto select styles by elements from the blocks checkout page and send them to WooPay on initialization.EPIC https://github.com/Automattic/woopay/issues/2781
SPIKE here
PT here
Screen.Recording.2024-07-17.at.7.22.50.AM.mov
Testing instructions
WooPay global theme supportfeature flagOR
Test 1:
getAppearanceReturn to cart-> Blocks checkout page -> WooPay buttonCheckout as guestand initialize WooPay as a new WooPay shopper with the email field redirectReturn to cart-> Blocks checkout pageTest 2:
getAppearancefor regressionReturn to cart-> Blocks checkout page -> WooPay buttonCheckout as guestand initialize WooPay as a new WooPay shopper with the email field redirectReturn to cart-> Blocks checkout pagenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge