-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Afterpay to process payments when the state field is optional (UK and NZ customers) #9079
Merged
danielmx-dev
merged 8 commits into
develop
from
fix/9046-allow-empty-state-when-optional-afterpay-gateway
Jul 16, 2024
Merged
Allow Afterpay to process payments when the state field is optional (UK and NZ customers) #9079
danielmx-dev
merged 8 commits into
develop
from
fix/9046-allow-empty-state-when-optional-afterpay-gateway
Jul 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptional for GB and NZ addresses
danielmx-dev
changed the title
Allow Afterpay gateway to process payments when the state/county is optional for GB and NZ addresses
Allow Afterpay gateway to process payments when the state/county is optional for UK and NZ customers
Jul 10, 2024
danielmx-dev
changed the title
Allow Afterpay gateway to process payments when the state/county is optional for UK and NZ customers
Allow Afterpay to process payments when the state/county is optional for UK and NZ customers
Jul 10, 2024
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: 0 B Total Size: 1.28 MB ℹ️ View Unchanged
|
danielmx-dev
changed the title
Allow Afterpay to process payments when the state/county is optional for UK and NZ customers
Allow Afterpay to process payments when the stateis optional for UK and NZ customers
Jul 11, 2024
danielmx-dev
changed the title
Allow Afterpay to process payments when the stateis optional for UK and NZ customers
Allow Afterpay to process payments when the state field is optional (UK and NZ customers)
Jul 11, 2024
danielmx-dev
requested review from
a team and
FangedParakeet
and removed request for
a team
July 11, 2024 14:52
FangedParakeet
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine and works as described. LGTM. 🚢
Co-authored-by: Samir Merchant <[email protected]>
danielmx-dev
deleted the
fix/9046-allow-empty-state-when-optional-afterpay-gateway
branch
July 16, 2024 17:28
lovo-h
pushed a commit
that referenced
this pull request
Aug 1, 2024
…UK and NZ customers) (#9079) Co-authored-by: Samir Merchant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9046
Changes proposed in this Pull Request
From #9046
This PR addresses this issue by checking the locale configuration from WooCommerce and applying the same rules in the Afterpay/Clearpay address validation.
Testing instructions
Before
An error appears and the order is not placed.
After
You will be redirected to the Stripe test page to authorize or fail the payment. If you authorize the payment the order will succeed.
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge