Fix Documents API regex to allow documents with dashes in name to be viewed #9084

jessepearson · 2024-07-11T14:17:52Z

Fixes #9083

Changes proposed in this Pull Request

Update the regex for documents to allow dashes in the document ID.

Testing instructions

Run npm run changelog to add a changelog file, choose patch to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.
Covered with tests (or have a good reason not to test in description ☝️)
Tested on mobile (or does not apply)

Post merge

Link to testing instructions from release testing doc following these instructions : Add link here / 'QA Testing Not Applicable'
Add or update critical flows and testing instructions for critical flows, if applicable.
Add what's changed (description, screenshot, demo videos etc.) to the release announcement post, if applicable.

botwoo · 2024-07-11T14:20:40Z

Test the build

Option 1. Jetpack Beta

Install and activate Jetpack Beta.
Use this build by searching for PR number 9084 or branch name fix/documents-api-regex in your-test.site/wp-admin/admin.php?page=jetpack-beta&plugin=woocommerce-payments

Option 2. Jurassic Ninja - available for logged-in A12s

🚀 Launch a JN site with this branch 🚀

ℹ️ Install this Tampermonkey script to get more options.

Build info:

Latest commit: ac4eb0f
Build time: 2024-07-11 14:52:17 UTC

Note: the build is updated when a new commit is pushed to this PR.

github-actions · 2024-07-11T14:23:12Z

Size Change: 0 B

Total Size: 1.28 MB

ℹ️ View Unchanged

Filename	Size
`release/woocommerce-payments/assets/css/admin.css`	1.08 kB
`release/woocommerce-payments/assets/css/admin.rtl.css`	1.08 kB
`release/woocommerce-payments/assets/css/success.css`	173 B
`release/woocommerce-payments/assets/css/success.rtl.css`	173 B
`release/woocommerce-payments/dist/blocks-checkout-rtl.css`	2.08 kB
`release/woocommerce-payments/dist/blocks-checkout.css`	2.08 kB
`release/woocommerce-payments/dist/blocks-checkout.js`	60.9 kB
`release/woocommerce-payments/dist/bnpl-announcement-rtl.css`	528 B
`release/woocommerce-payments/dist/bnpl-announcement.css`	529 B
`release/woocommerce-payments/dist/bnpl-announcement.js`	20.1 kB
`release/woocommerce-payments/dist/cart-block.js`	15.4 kB
`release/woocommerce-payments/dist/cart.js`	4.87 kB
`release/woocommerce-payments/dist/checkout-rtl.css`	600 B
`release/woocommerce-payments/dist/checkout.css`	600 B
`release/woocommerce-payments/dist/checkout.js`	31.7 kB
`release/woocommerce-payments/dist/express-checkout-rtl.css`	154 B
`release/woocommerce-payments/dist/express-checkout.css`	154 B
`release/woocommerce-payments/dist/express-checkout.js`	6.31 kB
`release/woocommerce-payments/dist/index-rtl.css`	41.1 kB
`release/woocommerce-payments/dist/index.css`	41 kB
`release/woocommerce-payments/dist/index.js`	295 kB
`release/woocommerce-payments/dist/multi-currency-analytics.js`	1.05 kB
`release/woocommerce-payments/dist/multi-currency-rtl.css`	3.41 kB
`release/woocommerce-payments/dist/multi-currency-switcher-block.js`	59.8 kB
`release/woocommerce-payments/dist/multi-currency.css`	3.41 kB
`release/woocommerce-payments/dist/multi-currency.js`	55 kB
`release/woocommerce-payments/dist/order-rtl.css`	730 B
`release/woocommerce-payments/dist/order.css`	730 B
`release/woocommerce-payments/dist/order.js`	42 kB
`release/woocommerce-payments/dist/payment-gateways-rtl.css`	1.35 kB
`release/woocommerce-payments/dist/payment-gateways.css`	1.35 kB
`release/woocommerce-payments/dist/payment-gateways.js`	38.9 kB
`release/woocommerce-payments/dist/payment-request-rtl.css`	154 B
`release/woocommerce-payments/dist/payment-request.css`	154 B
`release/woocommerce-payments/dist/payment-request.js`	5.9 kB
`release/woocommerce-payments/dist/plugins-page-rtl.css`	386 B
`release/woocommerce-payments/dist/plugins-page.css`	386 B
`release/woocommerce-payments/dist/plugins-page.js`	19.4 kB
`release/woocommerce-payments/dist/product-details-rtl.css`	397 B
`release/woocommerce-payments/dist/product-details.css`	398 B
`release/woocommerce-payments/dist/product-details.js`	11.2 kB
`release/woocommerce-payments/dist/settings-rtl.css`	11.2 kB
`release/woocommerce-payments/dist/settings.css`	11.1 kB
`release/woocommerce-payments/dist/settings.js`	215 kB
`release/woocommerce-payments/dist/subscription-edit-page.js`	668 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal-rtl.css`	524 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.css`	524 B
`release/woocommerce-payments/dist/subscription-product-onboarding-modal.js`	19.5 kB
`release/woocommerce-payments/dist/subscription-product-onboarding-toast.js`	694 B
`release/woocommerce-payments/dist/subscriptions-empty-state-rtl.css`	120 B
`release/woocommerce-payments/dist/subscriptions-empty-state.css`	120 B
`release/woocommerce-payments/dist/subscriptions-empty-state.js`	18.6 kB
`release/woocommerce-payments/dist/tokenized-payment-request-rtl.css`	154 B
`release/woocommerce-payments/dist/tokenized-payment-request.css`	154 B
`release/woocommerce-payments/dist/tokenized-payment-request.js`	6.62 kB
`release/woocommerce-payments/dist/tos-rtl.css`	235 B
`release/woocommerce-payments/dist/tos.css`	235 B
`release/woocommerce-payments/dist/tos.js`	21 kB
`release/woocommerce-payments/dist/woopay-direct-checkout.js`	5.25 kB
`release/woocommerce-payments/dist/woopay-express-button-rtl.css`	154 B
`release/woocommerce-payments/dist/woopay-express-button.css`	154 B
`release/woocommerce-payments/dist/woopay-express-button.js`	15.6 kB
`release/woocommerce-payments/dist/woopay-rtl.css`	4.26 kB
`release/woocommerce-payments/dist/woopay.css`	4.23 kB
`release/woocommerce-payments/dist/woopay.js`	69.6 kB
`release/woocommerce-payments/includes/subscriptions/assets/css/plugin-page.css`	625 B
`release/woocommerce-payments/includes/subscriptions/assets/js/plugin-page.js`	814 B
`release/woocommerce-payments/vendor/automattic/jetpack-assets/build/i18n-loader.js`	2.46 kB
`release/woocommerce-payments/vendor/automattic/jetpack-assets/src/js/i18n-loader.js`	1.02 kB
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.css`	198 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.js`	20 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-admin-create-user.rtl.css`	198 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.css`	625 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.js`	20 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-login.rtl.css`	626 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/jetpack-sso-users.js`	392 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-ajax.js`	521 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/dist/tracks-callables.js`	584 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.css`	215 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-admin-create-user.js`	521 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.css`	721 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-login.js`	412 B
`release/woocommerce-payments/vendor/automattic/jetpack-connection/src/sso/jetpack-sso-users.js`	520 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/babel.config.js`	159 B
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.css`	2.36 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.js`	13.6 kB
`release/woocommerce-payments/vendor/automattic/jetpack-identity-crisis/build/index.rtl.css`	2.36 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/about.css`	1.04 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-empty-state.css`	294 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin-order-statuses.css`	408 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/admin.css`	3.59 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/checkout.css`	301 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/modal.css`	746 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/view-subscription.css`	574 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/css/wcs-upgrade.css`	414 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin-pointers.js`	543 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/admin.js`	9.4 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.js`	6.78 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/jstz.min.js`	3.84 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-coupon.js`	545 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/meta-boxes-subscription.js`	2.52 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.js`	22.2 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/moment.min.js`	11.7 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/payment-method-restrictions.js`	1.29 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/admin/wcs-meta-boxes-order.js`	507 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/payment-methods.js`	358 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/single-product.js`	428 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/view-subscription.js`	1.38 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/frontend/wcs-cart.js`	782 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/modal.js`	1.09 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/assets/js/wcs-upgrade.js`	1.26 kB
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.css`	391 B
`release/woocommerce-payments/vendor/woocommerce/subscriptions-core/build/index.js`	3.04 kB

_{compressed-size-action}

dmvrtx

Makes sense! Pre-approving to let patch happen quickly.

Co-authored-by: César Costa <[email protected]>

…s updated (#9038)

Co-authored-by: Guilherme Pressutto <[email protected]>

…sactions report search box (#9072) Co-authored-by: Nagesh Pai <[email protected]>

…tion (#9047)

…viewed

jessepearson · 2024-07-11T14:55:59Z

Closing in favor of #9086 .
A release branch needed to be created, and things did not go well when trying to get this rebased to that branch.

dmvrtx approved these changes Jul 11, 2024

View reviewed changes

jessepearson self-assigned this Jul 11, 2024

jessepearson changed the base branch from develop to release/7.9.1 July 11, 2024 14:46

jessepearson changed the base branch from release/7.9.1 to develop July 11, 2024 14:46

asumaran and others added 6 commits July 11, 2024 11:47

Add ECE support for multiple product types (#8987)

b1e8d9d

Co-authored-by: César Costa <[email protected]>

Ensure order attribution inputs are not removed when shortcode cart i…

520f5e3

…s updated (#9038)

Deprecate Giropay (#9055)

d98f8ea

Co-authored-by: Guilherme Pressutto <[email protected]>

Reporting: Restore functioning of 'remove' button on last tag on tran…

0fa52eb

…sactions report search box (#9072) Co-authored-by: Nagesh Pai <[email protected]>

Register Independent ECE Payment Methods within the Blocks Implementa…

503afc3

…tion (#9047)

Fix Documents API regex to allow documents with dashes in name to be …

ac4eb0f

…viewed

jessepearson force-pushed the fix/documents-api-regex branch from d6e2e51 to ac4eb0f Compare July 11, 2024 14:49

jessepearson changed the base branch from develop to release/7.9.1 July 11, 2024 14:49

jessepearson closed this Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Documents API regex to allow documents with dashes in name to be viewed #9084

Fix Documents API regex to allow documents with dashes in name to be viewed #9084

jessepearson commented Jul 11, 2024 •

edited

Loading

botwoo commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading

dmvrtx left a comment

jessepearson commented Jul 11, 2024

Fix Documents API regex to allow documents with dashes in name to be viewed #9084

Fix Documents API regex to allow documents with dashes in name to be viewed #9084

Conversation

jessepearson commented Jul 11, 2024 • edited Loading

Changes proposed in this Pull Request

Testing instructions

botwoo commented Jul 11, 2024 • edited Loading

Test the build

Option 1. Jetpack Beta

Option 2. Jurassic Ninja - available for logged-in A12s

github-actions bot commented Jul 11, 2024 • edited Loading

dmvrtx left a comment

Choose a reason for hiding this comment

jessepearson commented Jul 11, 2024

jessepearson commented Jul 11, 2024 •

edited

Loading

botwoo commented Jul 11, 2024 •

edited

Loading

github-actions bot commented Jul 11, 2024 •

edited

Loading