Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Documents API regex to allow documents with dashes in name to be viewed #9086

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Fix Documents API regex to allow documents with dashes in name to be viewed #9086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/fix-9083-documents-api-regex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fix

Fix Documents API regex to allow documents with dashes in name to be viewed.
2 changes: 1 addition & 1 deletion includes/wc-payment-api/class-wc-payments-api-client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1795,7 +1795,7 @@ public function get_documents_summary( array $filters = [] ) {
* @throws API_Exception - If not connected or request failed.
*/
public function get_document( $document_id ) {
if ( ! preg_match( '/^\w+$/', $document_id ) ) {
if ( ! preg_match( '/^[\w-]+$/', $document_id ) ) {
throw new API_Exception(
__( 'Route param validation failed.', 'woocommerce-payments' ),
'wcpay_route_validation_failure',
Expand Down
Loading