Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payouts: Rename 'Bank reference key' to 'Bank reference ID' for consistency #9900

Merged
merged 2 commits into from
Dec 11, 2024
+14 −10
Merged

Payouts: Rename 'Bank reference key' to 'Bank reference ID' for consistency #9900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a0aeec
Rename to bank reference ID
Dec 9, 2024
8192513
changelog
Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions changelog/update-1-5316-rename-bank-reference-id
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: minor
Type: update

Change 'Bank reference key' label to 'Bank reference ID' in Payouts list column for consistency.
nagpai marked this conversation as resolved.
Show resolved Hide resolved
8 changes: 4 additions & 4 deletions client/deposits/list/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ const getColumns = ( sortByDate?: boolean ): DepositsTableHeader[] => [
isLeftAligned: true,
},
{
key: 'bankReferenceKey',
label: __( 'Bank reference key', 'woocommerce-payments' ),
screenReaderLabel: __( 'Bank reference key', 'woocommerce-payments' ),
key: 'bankReferenceId',
label: __( 'Bank reference ID', 'woocommerce-payments' ),
screenReaderLabel: __( 'Bank reference ID', 'woocommerce-payments' ),
},
];

Expand Down Expand Up @@ -170,7 +170,7 @@ export const DepositsList = (): JSX.Element => {
value: deposit.bankAccount,
display: clickable( deposit.bankAccount ),
},
bankReferenceKey: {
bankReferenceId: {
value: deposit.bank_reference_key,
display: clickable( deposit.bank_reference_key ?? 'N/A' ),
},
Expand Down
8 changes: 4 additions & 4 deletions client/deposits/list/test/__snapshots__/index.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,12 +321,12 @@ exports[`Deposits list renders correctly a single deposit 1`] = `
<span
aria-hidden="true"
>
Bank reference key
Bank reference ID
</span>
<span
class="screen-reader-text"
>
Bank reference key
Bank reference ID
</span>
</th>
</tr>
Expand Down Expand Up @@ -1009,12 +1009,12 @@ exports[`Deposits list renders correctly with multiple currencies 1`] = `
<span
aria-hidden="true"
>
Bank reference key
Bank reference ID
</span>
<span
class="screen-reader-text"
>
Bank reference key
Bank reference ID
</span>
</th>
</tr>
Expand Down
2 changes: 1 addition & 1 deletion client/deposits/list/test/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ describe( 'Deposits list', () => {
'Amount',
'Status',
'"Bank account"',
'"Bank reference key"',
'"Bank reference ID"',
];

const csvContent = mockDownloadCSVFile.mock.calls[ 0 ][ 1 ];
Expand Down
2 changes: 1 addition & 1 deletion client/types/deposits.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export interface DepositsTableHeader extends TableCardColumn {
| 'amount'
| 'status'
| 'bankAccount'
| 'bankReferenceKey';
| 'bankReferenceId';
cellClassName?: string;
}

Expand Down
Loading