Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding consistency: Use StepContainerV2 in 'Use domain I own' step #101739

Merged
merged 4 commits into from
Mar 24, 2025

Conversation

zaguiini
Copy link
Contributor

@zaguiini zaguiini commented Mar 21, 2025

Closes #101196.

Proposed Changes

  • Adds a "10" column version of the CenteredColumnLayout. It's based on the width of the 5+5 cols two column layout
  • Removed the showHeader prop from UseMyDomain component. It was unused
  • Added new hideHeader prop to UseMyDomain. This is so we can render the header using <Step.Header> instead. I thought it was better not to reuse the existing showHeader prop because I wanted it to be clear the default is false.
  • Wrap the "Use a domain I own" screens in the CenteredColumnLayout wireframe
  • Adjust styles so the step paddings follow the mockups.

CleanShot 2025-03-24 at 21 12 29@2x

CleanShot 2025-03-24 at 21 13 09@2x

CleanShot 2025-03-24 at 21 13 27@2x

CleanShot 2025-03-24 at 21 13 44@2x

CleanShot 2025-03-24 at 21 14 06@2x

CleanShot 2025-03-24 at 21 14 23@2x

Fix some design inconsistencies:

  • Domain input card has background but no borders, as well as some bottom margin that we can remove

Testing

There should be no changes unless the onboarding/step-container-v2 feature flag is enabled.

The UseMyDomain component is used in multiple places in the UI. We need to find them and ensure nothing has broken.

The second sub-step in the "Use a domain I own" screen has two variants, where sometimes there's two buttons and sometimes there's only one.

  • I used google.com to test the case where the domain can not be transferred.
  • I used neopets.com to test the case where it could be transferred.

@matticbot
Copy link
Contributor

matticbot commented Mar 21, 2025

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-stepper               +298 B  (+0.0%)       +6 B  (+0.0%)
entry-subscriptions          -13 B  (-0.0%)      -54 B  (-0.0%)
entry-main                   -13 B  (-0.0%)      -54 B  (-0.0%)
entry-login                  -13 B  (-0.0%)      -54 B  (-0.0%)
entry-domains-landing        -13 B  (-0.0%)      -54 B  (-0.0%)
entry-browsehappy            -13 B  (-0.0%)      -54 B  (-0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~3615 bytes removed 📉 [gzipped])

name                        parsed_size           gzip_size
async-step-use-my-domain       +24639 B  (+4.3%)    +9687 B  (+5.8%)
stepper-user-step                 -54 B  (-0.0%)     -130 B  (-0.1%)
signup                            -52 B  (-0.0%)      -19 B  (-0.0%)
async-step-unified-plans          -52 B  (-0.0%)      -17 B  (-0.0%)
async-step-unified-domains        -43 B  (-0.0%)      -14 B  (-0.0%)
domains                           +23 B  (+0.0%)      +10 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~182 bytes removed 📉 [gzipped])

name                                          parsed_size           gzip_size
async-load-signup-steps-new-or-existing-site        -13 B  (-0.0%)     -182 B  (-0.7%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@p-jackson p-jackson self-assigned this Mar 23, 2025
@matticbot
Copy link
Contributor

matticbot commented Mar 24, 2025

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • command-palette-wp-admin
  • help-center
  • notifications
  • odyssey-stats
  • whats-new

To test WordPress.com changes, run install-plugin.sh $pluginSlug onboarding/use-my-domain-step-uses-step-container-v2 on your sandbox.

@p-jackson p-jackson marked this pull request as ready for review March 24, 2025 07:11
@p-jackson p-jackson requested a review from a team as a code owner March 24, 2025 07:11
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2025
@p-jackson p-jackson marked this pull request as draft March 24, 2025 07:13
@p-jackson p-jackson force-pushed the onboarding/use-my-domain-step-uses-step-container-v2 branch from efe70a8 to da48e01 Compare March 24, 2025 08:11
@p-jackson p-jackson marked this pull request as ready for review March 24, 2025 08:22
@p-jackson
Copy link
Member

Domain input card has background but no borders, as well as some bottom margin that we can remove

@zaguiini I left this as it was since I believe we're not trying to fix up all the inconsistencies within the steps themselves?

@p-jackson p-jackson requested a review from a team March 24, 2025 08:22
? [
4 as const,
__( 'Use a domain I own' ),
__( 'Enter the domain you would like to use.' ),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I asked a question about this sub title here p1742799582663609-slack-C08HKNPL2BG

But it's not a blocker.

@zaguiini zaguiini merged commit 9fa8ff9 into trunk Mar 24, 2025
17 of 18 checks passed
@zaguiini zaguiini deleted the onboarding/use-my-domain-step-uses-step-container-v2 branch March 24, 2025 16:04
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 24, 2025
@a8ci18n
Copy link

a8ci18n commented Mar 24, 2025

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17314216

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators.

@a8ci18n
Copy link

a8ci18n commented Mar 25, 2025

Translation for this Pull Request has now been finished.

claudiucelfilip pushed a commit that referenced this pull request Mar 25, 2025
#101739)

* Use the new container

* Use Step.Heading component for domain transfer step

* Adjust "transfer-or-connect" styling

* Fix transfer-or-connect layout on mobile

---------

Co-authored-by: Philip Jackson <[email protected]>
jjchrisdiehl pushed a commit that referenced this pull request Mar 25, 2025
#101739)

* Use the new container

* Use Step.Heading component for domain transfer step

* Adjust "transfer-or-connect" styling

* Fix transfer-or-connect layout on mobile

---------

Co-authored-by: Philip Jackson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onboarding style consistency: Use domain I own screen
4 participants