-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding consistency: Use StepContainerV2 in 'Use domain I own' step #101739
Onboarding consistency: Use StepContainerV2 in 'Use domain I own' step #101739
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~6 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~3615 bytes removed 📉 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~182 bytes removed 📉 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
efe70a8
to
da48e01
Compare
@zaguiini I left this as it was since I believe we're not trying to fix up all the inconsistencies within the steps themselves? |
? [ | ||
4 as const, | ||
__( 'Use a domain I own' ), | ||
__( 'Enter the domain you would like to use.' ), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked a question about this sub title here p1742799582663609-slack-C08HKNPL2BG
But it's not a blocker.
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17314216 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @zaguiini for including a screenshot in the description! This is really helpful for our translators. |
Translation for this Pull Request has now been finished. |
#101739) * Use the new container * Use Step.Heading component for domain transfer step * Adjust "transfer-or-connect" styling * Fix transfer-or-connect layout on mobile --------- Co-authored-by: Philip Jackson <[email protected]>
#101739) * Use the new container * Use Step.Heading component for domain transfer step * Adjust "transfer-or-connect" styling * Fix transfer-or-connect layout on mobile --------- Co-authored-by: Philip Jackson <[email protected]>
Closes #101196.
Proposed Changes
CenteredColumnLayout
. It's based on the width of the 5+5 cols two column layoutshowHeader
prop fromUseMyDomain
component. It was unusedhideHeader
prop toUseMyDomain
. This is so we can render the header using<Step.Header>
instead. I thought it was better not to reuse the existingshowHeader
prop because I wanted it to be clear the default isfalse
.CenteredColumnLayout
wireframeFix some design inconsistencies:
Testing
There should be no changes unless the
onboarding/step-container-v2
feature flag is enabled.The
UseMyDomain
component is used in multiple places in the UI. We need to find them and ensure nothing has broken.The second sub-step in the "Use a domain I own" screen has two variants, where sometimes there's two buttons and sometimes there's only one.
google.com
to test the case where the domain can not be transferred.neopets.com
to test the case where it could be transferred.