Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated outdated loader explanation #38436

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

elenamik
Copy link
Contributor

@elenamik elenamik commented Dec 14, 2019

Changes proposed in this Pull Request

Testing instructions

  • Inspecting sections.js after webpack calls the loader, you can see that it adds a function, stored in section.load.
  • It seems the loader was simplified significantly in Framework: introduce sections middleware #21349, but the documentation did not reflect the changes.

Fixes #

@elenamik elenamik requested a review from a team as a code owner December 14, 2019 17:53
@elenamik
Copy link
Contributor Author

@jsnajdr please review!
The one thing I am not sure about is how / if the page.js route handlers are generated now. It seems to work quite differently than what is written in the doc.

@bluefuton bluefuton added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Documentation labels Dec 15, 2019
@lancewillett
Copy link
Contributor

Re-ping @jsnajdr

@sarayourfriend sarayourfriend changed the base branch from master to trunk November 20, 2020 16:14
@github-actions
Copy link

github-actions bot commented May 5, 2021

This PR has been marked as stale due to lack of activity within the last 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants