This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
add Jetpack.com "Try it free" connection flow #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brbrr
changed the title
bsessions85
reviewed
Mar 7, 2018
| } ); | ||
|
|
||
| test.it( 'Can log in', () => { | ||
| test.it( 'Can log in', function() { |
There was a problem hiding this comment.
I'm curious as to why you replaced all the arrow functions
There was a problem hiding this comment.
I've posted it here: #923 (comment)
this in arrow functions did not include mocha context, and sharing variables between tests becomes not possible
|
I re-ran the tests on CircleCI and that test passed but the one I fixed yesterday failed. |
…jetpackcom-try-free-flow
|
@bsessions85 I've merged master fixes and now tests are passing |
|
If I run the test with mocha('./node_modules/.bin/mocha specs-jetpack-calypso/wp-jetpack-connect-spec.js') it won't pass. I think it has to do with the WPCOM version being different. Is there some value I should be setting to run this locally?
|
|
Didn't have JETPACKHOST env variable set. LGTM! |
bsessions85
approved these changes
Mar 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect flow starting from Jetpack.com "Try it free" button (hits jetpack/connect/store flow) with logged ou WP.com account
#1000