Skip to content
This repository has been archived by the owner on Feb 18, 2021. It is now read-only.

Remove and address sleep statements in wp-jetpack-plans-spec.js #1737

Merged
merged 3 commits into from
Dec 28, 2018

Conversation

juliaamosova
Copy link
Contributor

Removed 2 sleep statements and addressed it by using waitTillPresentAndDislplayed in respective functions:

  • updated clickUpgradeNudge() in wp-admin-jetpack-page.js
  • updated clickPurchaseButton() in jetpack-plans-sales-page.js

waitTillPresentAndDislplayed adds the necessary check to make sure that both buttons are displayed and ready to be clicked on.

To test:

The change affects wp-jetpack-plans-spec.js.

Copy link
Contributor

@JavonDavis JavonDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments tests that are failing in CI are more than likely unrelated but Can create wporg site and connect Jetpack - [PRESSABLE] Gutenberg Markdown block: (desktop) @jetpack Publish a simple post with Markdown block is failing in CI and could be related... Did you test with that host?

@juliaamosova
Copy link
Contributor Author

The comments tests that are failing in CI are more than likely unrelated but Can create wporg site and connect Jetpack - [PRESSABLE] Gutenberg Markdown block: (desktop) @jetpack Publish a simple post with Markdown block is failing in CI and could be related... Did you test with that host?

Thanks @JavonDavis! The explanation of the failing tests is below:

Failing Jetpack tests:

Failing CI test:

  • 2 are related to the Comments - same as above - unrelated to the change I made;
  • 1 test is affecting wp-admin-jetpack-page.js but not related to the changes I made in thir PR:

Can create wporg site and connect Jetpack - [PRESSABLE] Gutenberg Markdown block: (desktop) @jetpack Publish a simple post with Markdown block:

Timed out waiting for element with css selector of 'a.jp-jetpack-connect__button' to be clickable

The code that doesn't work is here:

async connectWordPressCom() {

There is yet another sleep statement that needs to be addressed. I am already working on it :) It will be addressed in a separate PR since it is a different issue.

Copy link
Contributor

@JavonDavis JavonDavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on desktop and mobile 👍🏽

@juliaamosova juliaamosova merged commit e5f93fe into master Dec 28, 2018
@juliaamosova juliaamosova deleted the update/remove-sleep-wp-jetpack-plans branch December 28, 2018 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Status] Needs Jetpack e2e Testing Run full Jetpack e2e suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants