This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Remove and address sleep statements in wp-jetpack-plans-spec.js
#1737
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed 2
sleep
statements and addressed it by usingwaitTillPresentAndDislplayed
in respective functions:clickUpgradeNudge()
inwp-admin-jetpack-page.js
clickPurchaseButton()
injetpack-plans-sales-page.js
waitTillPresentAndDislplayed
adds the necessary check to make sure that both buttons are displayed and ready to be clicked on.To test:
The change affects
wp-jetpack-plans-spec.js
.