This repository has been archived by the owner on Feb 18, 2021. It is now read-only.
Put back classic editor comment test #1738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-e2e-tests into add/classic-editor-comment
Stojdza
added
[Status] Needs Review
[Status] Needs Jetpack e2e Testing
brbrr
reviewed
Dec 27, 2018
|
@JavonDavis This space caused a problem with tests execution. I fixed it and ran tests. Failed ones seem not related to this change. Is it good to go? |
My bad I actually resolved this through Github's online interface to test out that... Yep good to go! |
|
Thanks folks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #1729 caused that comments test is not passing for jetpack sites. I've removed
@jetpacktag fromCommenting and replying to newly created post in Gutenberg Editor:and put back testCommenting and replying to newly created post:.To test:
Make sure that
wp-comments-spec.jsis passing against jetpack sites.