-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
@brbrr I'm having trouble running this new spec locally. I'm set up using the all new instructions (great by the way!) and can run the jp connect spec ok using: When I run: I get:
|
@seear Ah, sorry. I've added testing steps, so with defined JETPACKHOST - it should be fine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so great to have an e2e test for this flow, because it is one of the most fiddly to test manually and often gets missed out.
The tests pass for me. Code looks fine. Great work 👍
test.it( 'Can disconnect any expired sites', () => { | ||
this.sidebarComponent = new SidebarComponent( driver ); | ||
|
||
const removeSites = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be good to factor this removeSites
function out so that it can be shared with the jetpack connect spec. That can be for a future PR because this one is large already.
@Automattic/flowpatrol ready for review :) |
I noticed that this spec is set up to always use Jurassic Ninja as the host, even when |
Thanks for your suggestion @rachelmcr |
f2da534
to
5b79fd5
Compare
Looks good and worked well for me:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adds SSO connect flow as requested in #777
To test this specific flow:
subscriberUser
is in your confgJETPACKHOST
env var toPRESSABLE
/JN
: e.gexport JETPACKHOST=PRESSABLE
./node_modules/.bin/mocha ./specs-jetpack-calypso/wp-jetpack-sso-connect-spec.js -g 'Connect via SSO'