Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use object_centers.csv in share directory #47

Merged
merged 5 commits into from
Jun 27, 2024
Merged

feat: use object_centers.csv in share directory #47

merged 5 commits into from
Jun 27, 2024

Conversation

KentaKato
Copy link
Contributor

課題

simple_lidar_simulator.cpp にて config/object_centers.csv を相対パスで指定しており、 ros2 launch autoware_practice_launch practice.launch.xml を実行可能なディレクトリに制約があった

対応

config ディレクトリを share に install した

テスト方法

任意のディレクトリで ros2 launch autoware_practice_launch practice.launch.xml が実行可能なことを確認

よろしくお願いいたします。

Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正ありがとうございます! 一点以下の対応をお願いできますか?

src/autoware_practice_lidar_simulator/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Takagi, Isamu <[email protected]>
@isamu-takagi isamu-takagi enabled auto-merge (squash) June 27, 2024 09:12
@isamu-takagi isamu-takagi merged commit 12acc1c into AutomotiveAIChallenge:main Jun 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants