Fix data desync issues #266
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I've merged this into develop, in the future if you could open to that instead of master so it shows as merged here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason previous code causes data to not be saved.
Also there is a issue when player disconnect from the server and his data will not be saved, due to unloading his profile in quit event, so his changed data will disappear, and then ProfileSaver will try to save new data, but his profile is null, so it will loaded from database without any changes.
After this commit, if player disconnects and his profile had any changes it will not be saved, so you need to make sure to save player data when player leaves.
Fixes: #244 #208 and maybe #118