Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the known valuator do not update. #17321

Merged

Conversation

lindexi
Copy link
Contributor

@lindexi lindexi commented Oct 22, 2024

What does the pull request do?

After this change, the properties Pressure, Touch Major, and Touch Minor will refresh their values in response to device changes.

What is the current behavior?

Before this change, the properties Pressure, Touch Major, and Touch Minor would not update when the device changed.

Reference: #16498

The properties Pressure, Touch Major, and Touch Minor will only update in Init method.

What is the updated/expected behavior with this PR?

After this change, the properties Pressure, Touch Major, and Touch Minor will refresh their values in response to device changes.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@lindexi lindexi marked this pull request as ready for review October 22, 2024 02:44
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0052757-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Before this change, the properties Pressure, Touch Major, and Touch Minor would not update when the device changed.

After this change, the properties Pressure, Touch Major, and Touch Minor will refresh their values in response to device changes.
@lindexi lindexi force-pushed the t/lindexi/UpdateTouchKnownValuator branch from a099885 to 4ba2b4c Compare November 20, 2024 11:52
@lindexi lindexi requested a review from MrJul November 20, 2024 12:00
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.3.999-cibuild0053464-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@MrJul MrJul added this pull request to the merge queue Nov 23, 2024
Merged via the queue into AvaloniaUI:master with commit f977d22 Nov 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants