Fix: respect CanResize on macOS regardless of SystemDecorations #17355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR moves
NSWindowStyleMaskResizable
flag application fromSystemDecorationsFull
case outside of the switch, so this flag is applied also for other system decorations.What is the current behavior?
NSWindowStyleMaskResizable
is applied only forSystemDecorationsFull
. Other decorations make windows not resizable.What is the updated/expected behavior with this PR?
NSWindowStyleMaskResizable
is applied regardless of SystemDecorations, it always followsCanResize
property.Checklist
Breaking changes
Windows which have decorations set to
None
orBorderOnly
andCanResize=true
(default) will now become resizable, which can be unexpected for some people. But this behaviour is expected since CanResize is set to true, isn't it?Obsoletions / Deprecations
Fixed issues
Fixes #17295